Skip to content

Fix convenience variables for proxy #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

Fix convenience variables for proxy #735

merged 2 commits into from
Jul 22, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jul 11, 2025

PR #717 added some convenience proxy vars, but the logic wasn't quite correct. This:

  • Makes it so simply defining proxy_http_address is enough to produce a correct proxy_http_proxy variable (which in turn is all that is required to produce a working proxy config if the other defaults are sufficent).
  • Fixes a whitespace issue.

@sjpb sjpb marked this pull request as ready for review July 11, 2025 15:13
@sjpb sjpb requested a review from a team as a code owner July 11, 2025 15:13
bertiethorpe
bertiethorpe approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@bertiethorpe bertiethorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit c4e4cb2 into main Jul 22, 2025
2 checks passed
@sjpb sjpb deleted the fix/proxy-vars branch July 22, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertiethorpe bertiethorpe bertiethorpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @bertiethorpe